added ability to overwrite the job display name using a job setting #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * {@code new JobSetting.DisplayName}. | ||
| * | ||
| * @param displayName | ||
| * The job's display name. |
|
Is this ready to be merged? |
|
@aozarov is completely happy with the current behaviour. But I have not had a chance to change it. I have resorted to using it as it is. Edit: |
|
Just to make it clear. Indeed I am fine with current behavior but adding another way to specify the name via JobSetting as proposed (explicit method override should win) is nice. I don't think you need to change much to make it happen. |
|
@soundofjw this is Java, not Python 😜 |
|
@billy1380 thanks ;) 🐝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23