Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2DBC connection property names should match the JDBC ones #1614

Open
ttosta-google opened this issue Oct 13, 2023 · 0 comments
Open

R2DBC connection property names should match the JDBC ones #1614

ttosta-google opened this issue Oct 13, 2023 · 0 comments
Assignees
@hessjcg
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ttosta-google
Copy link
Collaborator

ttosta-google commented Oct 13, 2023 •
edited
Loading

Currently the doc r2dbc.md does not specify that the options can be added to the URL. However it can and works.

Example:

r2dbc:gcp:mysql://<DB_USER>:<DB_PASS>@<CLOUD_SQL_CONNECTION_NAME>/<DATABASE_NAME>?TARGET_PRINCIPAL=<IAM_EMAIL>

To make the connection property names match the JDBC ones, we should update GcpConnectionFactoryProvider.java:

  • unixSocketPath
  • ipTypes
  • cloudSqlDelegates
  • cloudSqlTargetPrincipal
  • enableIamAuth

Also update the doc r2dbc.md.

Note: we need to support both the old options TARGET_PRINCIPAL and the common options cloudSqlTargetPrincipal just in case some customers figured out how to use TARGET_PRINCIPAL in the r2dbc url.
@ttosta-google ttosta-google added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 13, 2023
@ttosta-google ttosta-google self-assigned this Oct 13, 2023
@ttosta-google ttosta-google changed the title R2DBC URL options should match the R2DBC URL options should match JDBC Oct 13, 2023
@ttosta-google ttosta-google changed the title R2DBC URL options should match JDBC R2DBC URL options should match JDBC ones Oct 13, 2023
@ttosta-google ttosta-google changed the title R2DBC URL options should match JDBC ones R2DBC connection property names should match the JDBC ones Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hessjcg hessjcg

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ttosta-google @hessjcg