Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run/custom-metrics doesn't add SIGTERM/SIGINT handler for graceful shutdown #3554

Open
aabmass opened this issue Nov 3, 2023 · 0 comments
Open

run/custom-metrics doesn't add SIGTERM/SIGINT handler for graceful shutdown #3554

aabmass opened this issue Nov 3, 2023 · 0 comments
Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. stale: old Pull request is old and needs attention. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@aabmass
Copy link
Contributor

aabmass commented Nov 3, 2023

The Go program should add SIGTERM handler to shutdown the SDK. Right now it will just be ungracefully shutdown by Go's default SIGTERM handler, which means telemetry won't be flushed. See https://cloud.google.com/run/docs/samples/cloudrun-sigterm-handler
@aabmass aabmass added priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 3, 2023
@product-auto-label product-auto-label bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Nov 3, 2023
@subfuzion subfuzion added the stale: old Pull request is old and needs attention. label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. stale: old Pull request is old and needs attention. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@subfuzion @aabmass and others