Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process output longer than 64k swallows all remaining logging #215

Open
zachmu opened this issue Jun 21, 2023 · 0 comments
Open

Process output longer than 64k swallows all remaining logging #215

zachmu opened this issue Jun 21, 2023 · 0 comments
Assignees

Comments

@zachmu
Copy link

zachmu commented Jun 21, 2023

This is basically the same feedback as #149, which I don't have permission to reopen.

Our customer just hit this problem. A process logging a line longer than 64k (the default buffer size for bufio.NewScanner) will swallow any output up to that point and after. Our process is a database that under some logging configurations logs query strings, which can be arbitrarily long. This makes it difficult to debug crashes in particular since any panic output or similar will not be logged.

Asking users to change the logging behavior of binaries they don't own is not a feasible workaround. Making the buffer size configurable via parameters / environment variables would be. Better yet: have fallback behavior when the scanner buffer overflows, rather than refusing to log output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants