-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle retry logic and error logging internally #181
Comments
@aabmass , any updates on this? Appears to be throwing this every time it tries to send traces to Google Trace, which is making logs semi-unreadable. Are non Googler PRs accepted in this repo? |
What are you seeing in your logs exactly?
PRs are welcome 😄 You just need to sign the CLA! |
Gotcha! When on 0.13.0 (OT core/api), ExportResult.FAILED_RETRYABLE does not exist and an unhandled exception is thrown from a catch block (_batchWriteSpans, trace.js) Switching to 0.12.0 - we were actually hitting the trace api rate limit 🤒. The BatchSpanProcessor's (which calls export) resultCallback has an empty .catch() block (so any non SUCCESS will have an unhandled exception warning message) |
Oh, I didn't realize 0.13.0 was released. The peer dependency in this package is accurate, so it currently only works with 0.12. Let me see how simple updating it is.
Got it. 0.13 should fix the unhandled exception |
@aabmass will open a new issue, original issue is probably resolved but the discussion has brought up new topics |
The actual issue I opened this bug for is fixed. I am tracking retries issues in #523 |
Context: open-telemetry/opentelemetry-js#1561 (comment)
ExportResult.FAILED_RETRYABLE
will be removed from the OTel JS (open-telemetry/opentelemetry-js#1569) as retries should be handled by the exporter. In addition, the error logging should also be handled in the exporter atm.This will fix thetheUnhandledPromiseRejectionWarning: undefined
warnings that appear when the metric exporter fails (like when the interval is <5 seconds).UnhandledPromiseRejectionWarning: undefined
should be fixed but we could add some more specific logging.The text was updated successfully, but these errors were encountered: