Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle retry logic and error logging internally #181

Closed
aabmass opened this issue Oct 6, 2020 · 6 comments
Closed

Handle retry logic and error logging internally #181

aabmass opened this issue Oct 6, 2020 · 6 comments
Assignees
Labels
bug Something isn't working trace

Comments

@aabmass
Copy link
Contributor

aabmass commented Oct 6, 2020

Context: open-telemetry/opentelemetry-js#1561 (comment)

ExportResult.FAILED_RETRYABLE will be removed from the OTel JS (open-telemetry/opentelemetry-js#1569) as retries should be handled by the exporter. In addition, the error logging should also be handled in the exporter atm. This will fix the UnhandledPromiseRejectionWarning: undefined warnings that appear when the metric exporter fails (like when the interval is <5 seconds). the UnhandledPromiseRejectionWarning: undefined should be fixed but we could add some more specific logging.

@aabmass aabmass added the bug Something isn't working label Oct 6, 2020
@bkspace
Copy link

bkspace commented Dec 8, 2020

@aabmass , any updates on this? Appears to be throwing this every time it tries to send traces to Google Trace, which is making logs semi-unreadable.

Are non Googler PRs accepted in this repo?

@aabmass
Copy link
Contributor Author

aabmass commented Dec 9, 2020

What are you seeing in your logs exactly?

Are non Googler PRs accepted in this repo?

PRs are welcome 😄 You just need to sign the CLA!

@bkspace
Copy link

bkspace commented Dec 9, 2020

Gotcha!

When on 0.13.0 (OT core/api), ExportResult.FAILED_RETRYABLE does not exist and an unhandled exception is thrown from a catch block (_batchWriteSpans, trace.js)

Switching to 0.12.0 - we were actually hitting the trace api rate limit 🤒. The BatchSpanProcessor's (which calls export) resultCallback has an empty .catch() block (so any non SUCCESS will have an unhandled exception warning message)

@aabmass
Copy link
Contributor Author

aabmass commented Dec 9, 2020

Oh, I didn't realize 0.13.0 was released. The peer dependency in this package is accurate, so it currently only works with 0.12. Let me see how simple updating it is.

Switching to 0.12.0 - we were actually hitting the trace api rate limit 🤒. The BatchSpanProcessor's (which calls export) resultCallback has an empty .catch() block (so any non SUCCESS will have an unhandled exception warning message)

Got it. 0.13 should fix the unhandled exception

@damemi
Copy link
Contributor

damemi commented Jan 30, 2023

@aabmass will open a new issue, original issue is probably resolved but the discussion has brought up new topics

@aabmass
Copy link
Contributor Author

aabmass commented Feb 6, 2023

The actual issue I opened this bug for is fixed. I am tracking retries issues in #523

@aabmass aabmass closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working trace
Projects
None yet
Development

No branches or pull requests

4 participants