Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Testing instructions out of date #76

Open
duggelz opened this issue Aug 9, 2017 · 1 comment
Open

Testing instructions out of date #76

duggelz opened this issue Aug 9, 2017 · 1 comment

Comments

@duggelz
Copy link
Contributor

duggelz commented Aug 9, 2017

CONTRIB.md says that developers should test changes with make all DEBIAN_SUITE=jessie, but this gives an error message:

cd mkdebootstrap && docker build \
		-t google/mkdebootstrap \
		--build-arg DOCKER_VERSION=1.11.2 \
		.
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /usr/local/google/home/dgreiman/code/github/debian-docker/mkdebootstrap/Dockerfile: no such file or directory
make: *** [mkdebootstrap] Error 1

I think the instructions should instead be something like ./build.sh -r 'gcr.io/cloud-python-runtime-qa' -v jessie except using some other project name. And the Makefile should be updated or removed.

@sharifelgamal
Copy link
Contributor

I think the goal will be to remove the Makefile completely. Just need to change how the travis tests are run and update the README.

dlorenc pushed a commit that referenced this issue Nov 21, 2017
* fix tag check entrypoint

* update docs

* flake
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants