From 6b4ddb63c75875f1eb4bfcd04a804d986a6de277 Mon Sep 17 00:00:00 2001 From: Frank Sheiness Date: Tue, 8 Sep 2015 17:56:22 -0500 Subject: [PATCH 1/3] Remove extra ) --- dist/amChartsDirective.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dist/amChartsDirective.js b/dist/amChartsDirective.js index 872c4cd..230e5e1 100644 --- a/dist/amChartsDirective.js +++ b/dist/amChartsDirective.js @@ -189,7 +189,7 @@ angular.module('amChartsDirective', []).directive('amChart', ['$q', function ($q for (var i = 0;i < o.titles.length;i++) { var title = o.titles[i]; chart.addTitle(title.text, title.size, title.color, title.alpha, title.bold); - }); + }; } // WRITE From fec102123171eee3b4046b54a7ed24bb5605590e Mon Sep 17 00:00:00 2001 From: Frank Sheiness Date: Tue, 8 Sep 2015 22:51:05 -0500 Subject: [PATCH 2/3] Fix balloon config --- dist/amChartsDirective.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/dist/amChartsDirective.js b/dist/amChartsDirective.js index 230e5e1..6cd759c 100644 --- a/dist/amChartsDirective.js +++ b/dist/amChartsDirective.js @@ -156,17 +156,15 @@ angular.module('amChartsDirective', []).directive('amChart', ['$q', function ($q } chart.chartScrollbar = scrollbar; } + + if (o.balloon) { + chart.balloon = o.balloon; + } } function generatePieProperties() { if (o.balloon) { - var balloon = new AmBalloon(); - var keys = Object.keys(o.chartScrollbar); - var keys = Object.keys(o.chartScrollbar); - for (var i = 0; i < keys.length; i++) { - balloon[keys[i]] = o.balloon[keys[i]]; - } - chart.balloon = balloon; + chart.balloon = o.balloon; } } From 9e4ef285a8592a7c1d16c279842e6215ae160917 Mon Sep 17 00:00:00 2001 From: Frank Sheiness Date: Tue, 8 Sep 2015 22:53:54 -0500 Subject: [PATCH 3/3] Fix attribute to allow use of % symbol in height and width --- dist/amChartsDirective.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dist/amChartsDirective.js b/dist/amChartsDirective.js index 6cd759c..058731b 100644 --- a/dist/amChartsDirective.js +++ b/dist/amChartsDirective.js @@ -7,8 +7,8 @@ angular.module('amChartsDirective', []).directive('amChart', ['$q', function ($q replace: true, scope: { options: '=', - height: '=', - width: '=' + height: '@', + width: '@' }, template: '
', link: function ($scope, $el) {