Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsive layout for .subtitle and .sort-buttons on screens below 947px #313

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

ahmedrazabaloch
Copy link
Contributor

This PR modifies the styling for screen widths below 947px, specifically targeting .subtitle and .sort-buttons.

Removed the top and bottom margin for the .subtitle class to improve visual consistency in smaller viewports.
Centered the content of the .sort-buttons class for better alignment on narrower screens.
Fixes #(issue number)

Type of change
Bug fix (non-breaking change)
How Has This Been Tested?
The following tests were performed to ensure the changes work correctly across relevant screen sizes:

Verified that the .subtitle no longer has top or bottom margins on screens narrower than 947px.
Checked that the .sort-buttons are centered correctly when the screen width is below 947px.
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

@ahmedrazabaloch
Copy link
Contributor Author

"Please note that I've raised three additional PRs to address other issues, mainly to meet my Hacktoberfest goal as the month is nearing its end. I decided to break the changes into multiple PRs for clarity and easier review, but all are part of the effort to fix responsive layout issues across the project. Thank you for your understanding!"

… to improve the layout of the .sort-filter-container. The changes center the content inside .sort-filter-container to ensure better alignment and user experience on smaller devices.
@Anshgrover23
Copy link
Collaborator

@ahmedrazabaloch kindly do not tell us your plan 😂. kindly share before and after screenshots?

@ahmedrazabaloch
Copy link
Contributor Author

before
screencapture-127-0-0-1-5500-Todo-html-2024-10-25-03_22_44
after
screencapture-127-0-0-1-5500-Todo-html-2024-10-25-03_33_39

@Anshgrover23
Copy link
Collaborator

@ahmedrazabaloch kindly resolve conflicts.

@Anshgrover23 Anshgrover23 merged commit ec0a47c into Groverio:main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants