-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSIS Uninstaller hangs if EnVar plugin and Banner are called #10
Comments
Thanks for your report. I hardly guess your issue is not related to the EnVar plugin, also your edit seems to confirm my assumption. I'm aware of the issue with the hanging uninstaller, if I recall correctly I also had this issue without the EnVar plugin. But here it's not a permanent issue, sometimes it works, sometime the install hangs at the end. Is it okay for you closing this issue? |
Well, the issue didn't appear until we added EnVar to our installer. We are only using to modify the PATH variable without the NSIS 1024 character limitation. |
This is happening to us as well. Sometimes the installer's (never had it with the uninstaller though) process just sits there after the interactive window is closed. Also happens in silent mode. |
Will try to reproduce with you script above... |
I wonder whether there are any asynchronous calls within this library? Might be that the dll is not unloaded .. |
I suspect this may be an issue with NSIS rather than EnVar, but I am not sure, so I am posting here for now.
When calling both EnVar and Banner from an unattended uninstaller, very often the uninstaller will hang after completing its work, with full CPU use on one thread. I cannot say exactly where the freeze occurs, but is after the un.onUninstSuccess handler is completed.
Minimal reproduction case (used NSIS version is 3.06.1, EnVar 0.3.1):
Can be tested with a batch script like this:
EDIT:
Appending
/NOUNLOAD
to theBanner::destroy
fixes the issueThe text was updated successfully, but these errors were encountered: