Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding the Range of Supported QEMU Devices: Introducing NVMe Storage #595

Open
zjmletang opened this issue Feb 18, 2025 · 5 comments
Open

Comments

@zjmletang
Copy link
Contributor

I've noticed that our current HCK devices are mostly Virtio devices. I would like to ask if we could also support other QEMU devices, such as NVMe storage devices

@YanVugenfirer
Copy link
Contributor

YanVugenfirer commented Feb 18, 2025

Hi @zjmletang,

You just need to create the appropriate configuration file.
@kostyanf14 for devices like NVMe that have inbox driver we need to skip driver installation, is there a problem with it?

@zjmletang
Copy link
Contributor Author

@YanVugenfirer Thank you very much. In our scenario, we are using a custom-developed NVMe driver instead of Microsoft's inbox NVMe driver.

@YanVugenfirer
Copy link
Contributor

@kostyanf14 can the virtio-scsi device be used as a sample or additional change is needed? https://github.com/HCK-CI/AutoHCK/blob/master/lib/engines/hcktest/drivers/vioscsi.json

@kostyanf14
Copy link
Contributor

@YanVugenfirer @zjmletang

There are 2 different things

  1. NVME device for QEMU - just create a new device for example lib/setupmanagers/qemuhck/devices/virtio-scsi-pci.json
  2. NVME driver - can be a problem because pnputil can fail to install the driver because Mivrosoft one (signed) is present

Answering to your first question:

I would like to ask if we could also support other QEMU devices, such as NVMe storage devices

You can send a PR if you want. We update/extend AutoHCK for devices/drivers that we need for some reason but we ok to extend it with any devices that are supported by QEMU.

@zjmletang
Copy link
Contributor Author

@kostyanf14 ,Okay, once I verify it on my end, I'll submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants