Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CD: Clean up docker postgres variables #233

Open
2 tasks
SarahJaine opened this issue Dec 17, 2020 · 0 comments
Open
2 tasks

CD: Clean up docker postgres variables #233

SarahJaine opened this issue Dec 17, 2020 · 0 comments
Labels
JIRA Post MVP Issues cut from the MVP scope

Comments

@SarahJaine
Copy link
Contributor

It seems to me that we're specifying the POSTGRES_USER and POSTGRES_DB several times in the CD pipeline.

  1. When the docker-executor is declared https://github.com/adhocteam/Head-Start-TTADP/blob/main/.circleci/config.yml#L5-L16
  2. In docker-compose-test https://github.com/adhocteam/Head-Start-TTADP/blob/main/docker-compose-test.yml#L23-L29
  3. In cucumber_test and accessibility_scan jobs

Acceptance criteria

  • choose leanest implementation
  • remove redundant var specification
@marriej marriej added the Post MVP Issues cut from the MVP scope label Feb 9, 2021
@marriej marriej added the JIRA label Mar 3, 2021
rahearn added a commit that referenced this issue Mar 13, 2021
@rahearn
Merge pull request #233 from adhocteam/js-360-filter-reports-to-approved
9532b3c 
Filter main report table to approved reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JIRA Post MVP Issues cut from the MVP scope
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SarahJaine @marriej