Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX and Documentation issues #57

Open
majora2007 opened this issue Sep 24, 2023 · 2 comments
Open

UX and Documentation issues #57

majora2007 opened this issue Sep 24, 2023 · 2 comments

Comments

@majora2007
Copy link
Contributor

Here are a few things I'm noticing while using this library. This issue is here for discussion and any items I can take and raise a PR for.

  1. autoCreate by itself does not always ensure the search box is visible. I found you need to use displaySearchStatus=always. This is something I missed (the example documentation worked without this but in my app, it does not).
  2. updateEvent is triggering when autoCreateItem is emitted. I think it should be suppressed for this case. I need feedback here as remove option will emit an update, but for adding a new one, the value is of a string and not the underlying item.
  3. Search box could benefit from Placeholder to help the end user know. If no autocreate, then "Filter", else "Filter or create new item". This could help a ton for end users. Ideally we'd expose this as an input.
  4. autoCreate on adding can leave some empty state in the search box which doesn't show the remaining options unless search box is cleared out (this only happens in my app, not in example page)
  5. autoCreate mode might want a button to indicate to the user they can add (or an option that's not selectable to tell them they can add"
    image
@majora2007
Copy link
Contributor Author

@Zefling thoughts on item 2? I've started working on this to streamline the new feature.

@Zefling
Copy link
Collaborator

Zefling commented Oct 1, 2023

If the proposal is coherent and does not break the existing, you can propose an evolution.
This is not a feature I personally need for the projects I work on.
The component is already a fork of another project, I haven't really taken the time to review certain points that could clearly be improved.

  1. It's true that it's not super consistent with the documentation. I forgot this point.
  2. Perhaps the sending should be made more consistent indeed.
  3. Perhaps going up in the "selection" rather than the "dropdown" will be more consistent.
  4. If it's more consistent, I don't have a use case
  5. I like the proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants