Fix null function reference for IntIterator #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why hasn't this been pushed yet? |
Because requested change hasn't been made. |
|
I didn't even realize there was a requested change on this since it was posted on the issue and not the PR! Will fix this now. |
EliteMasterEric
force-pushed
the
fix-null-function-intiterator
branch
from
a1b7f74 to
2e59640
Compare
|
Made the desired change and rebased, this should be good to go now. |
kLabz
reviewed
Feb 14, 2025
| @@ -562,7 +562,8 @@ class Interp { | |||
| return (v : Array<Dynamic>).iterator(); | |||
| if( v.iterator != null ) v = v.iterator(); | |||
| #else | |||
| try v = v.iterator() catch( e : Dynamic ) {}; | |||
| #if (cpp) if ( v.iterator != null ) #end | |||
| try v = v.iterator() catch( e : Dynamic ) {}; | |||
There was a problem hiding this comment.
Is the try/catch necessary on cpp after the nullcheck? If not, this could go with the flash/php #if above
There was a problem hiding this comment.
not sure, I left it on to be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114, tested and found no difference in the behavior of scripts.