Fix model display issue in request table view #2787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![use-tusk[bot]](https://avatars.githubusercontent.com/in/385172?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
colegottdank
requested changes
Oct 16, 2024
| @@ -194,9 +194,17 @@ const isAssistantRequest = (request: HeliconeRequest) => { | |||
|
|
|||
| const getNormalizedRequest = (request: HeliconeRequest): NormalizedRequest => { | |||
| try { | |||
| return getRequestBuilder(request).build(); | |||
| const normalizedRequest = getRequestBuilder(request).build(); | |||
There was a problem hiding this comment.
This is not solving the issue. If the model in the images correctly shows in the request drawer, it should also show correctly in the request page. There is another issue here.
|
Addressing your review. View activity logs for details. |
use-tusk
bot
force-pushed
the
tusk-2784-fix-model-display-101620241919
branch
from
160cb92
to
19271fb
Compare
use-tusk
bot
force-pushed
the
tusk-2784-fix-model-display-101620241919
branch
from
5ff1eb4
to
a50824c
Compare
use-tusk
bot
force-pushed
the
tusk-2784-fix-model-display-101620241919
branch
from
62abe59
to
2b20134
Compare
use-tusk
bot
force-pushed
the
tusk-2784-fix-model-display-101620241919
branch
from
a5472c6
to
0834ec3
Compare
|
@colegottdank I've addressed your review, but the automated checks are failing. If the PR is still not correct, consider closing it with a comment explaining why. This will improve my future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2784
This PR addresses the bug where the model information was not displaying correctly in the table view of requests, while it showed up correctly in the individual request view. The following changes were made to fix this issue:
useGetRequestsWithBodieshook to improve model extraction logic from various sources.getNormalizedRequestfunction to handle cases with missing or undefined model information by setting it to "Unsupported".RequestRowcomponent correctly passes model information to theModelPillcomponent.ModelPillcomponent to display "Unsupported" when the model information is not available.Tips: