Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint impl for ErrorInto is missing extension forwarding #74

Closed
1 task done
thespooler opened this issue Jan 28, 2020 · 0 comments
Closed
1 task done

Endpoint impl for ErrorInto is missing extension forwarding #74

thespooler opened this issue Jan 28, 2020 · 0 comments
Labels
bug

Comments

@thespooler
Copy link
Contributor

thespooler commented Jan 28, 2020 •
edited
Loading

Bug report

As discussed in #38, the Endpoint impl for ErrorInto is missing extension forwarding and falls back to the basic impl Endpoint returning None, meaning no extensions will get invoked.

The effects of this bug are that any Endpoint wrapped in ErrorInto will ignore any extension present.

Reproduction

thespooler/oxide-actix-pcke@558480d

Expected behaviour

In the sample, PKCE extension is present on Extended<> and should be invoked.
But the wrapping in ErrorInto in with_sollicitor prevents that because of the present bug.

Tracking pull request

  • A pull request (does not yet exist)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thespooler