Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RuntimeError based on error code #39

Open
nicholasruunu opened this issue Nov 17, 2014 · 3 comments
Open

Make RuntimeError based on error code #39

nicholasruunu opened this issue Nov 17, 2014 · 3 comments

Comments

@nicholasruunu
Copy link

I made this pull request for a fork of this project: https://github.com/elfet/php-ssh/pull/1

Is this something that would be interesting for this project?

@Herzult
Copy link
Owner

Herzult commented Nov 18, 2014

Interesting input. We must be careful as it changes the subsystem's behavior. My first reaction would be to keep the actual behavior by default and to provide a simple way to activate this output code trick.

@nicholasruunu
Copy link
Author

That sounds reasonable.

Sent from my iPhone

On 18 Nov 2014, at 10:38, Antoine Hérault [email protected] wrote:

Interesting input. We must be careful as it changes the subsystem's behavior. My first reaction would be to keep the actual behavior by default and to provide a simple way to activate this output code trick.


Reply to this email directly or view it on GitHub.

@dirkluijk
Copy link

What's the status of this issue? I am really interested to have this in Herzult/php-ssh because I am having a problem right now.

After executing npm install via SSH2, an exception is thrown because it assumes an error has occured (which is not the case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants