Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdig 0.40.0 #208597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sysdig 0.40.0 #208597

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Feb 22, 2025

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.
release notes
## What's Changed
* update(deps): bump libs to 0.19.0 by @therealbobo in https://github.com/draios/sysdig/pull/2129
* refactor(ci): integrate arm64 runners + zig build by @therealbobo in https://github.com/draios/sysdig/pull/2130
* fix(release-draft): adopt new download/upload artifact api by @therealbobo in https://github.com/draios/sysdig/pull/2133
* update(deps): bump to libs 0.20.0 and driver 8.0.0 by @therealbobo in https://github.com/draios/sysdig/pull/2134
* feat: add 8.0.0 driver configs by @therealbobo in https://github.com/draios/sysdig/pull/2135
* cleanup(ci): semplify ci by @therealbobo in https://github.com/draios/sysdig/pull/2137
* build: Add support for linking to shared falcosecurity libraries. by @Apteryks in https://github.com/draios/sysdig/pull/2093
* cleanup: correctly exclude distros from driverkit by @therealbobo in https://github.com/draios/sysdig/pull/2139
* fix(ci): correctly sign packages by @therealbobo in https://github.com/draios/sysdig/pull/2140
* fix(ci): use debsig-verify by @therealbobo in https://github.com/draios/sysdig/pull/2142
* fix(release): use gpg verify by @therealbobo in https://github.com/draios/sysdig/pull/2143
* fix(ci): skip sign verify by @therealbobo in https://github.com/draios/sysdig/pull/2145
* fix(release): install gnupg2 needed for rpm signing by @therealbobo in https://github.com/draios/sysdig/pull/2146
* fix(release): use new docker creds by @therealbobo in https://github.com/draios/sysdig/pull/2147

New Contributors

Full Changelog: draios/sysdig@0.39.0...0.40.0

@github-actions github-actions bot added lua Lua use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Feb 22, 2025
Co-authored-by: Carlo Cabrera <[email protected]>
@p-linnane
Copy link
Member

@Homebrew/core draios/sysdig@6117c49 added an option to no longer use the bundled falcosecurity-libs. We can either package our own, or add -DUSE_BUNDLED_FALCOSECURITY_LIBS=ON here. Thoughts?

@alebcay
Copy link
Member

alebcay commented Feb 23, 2025

My general rule of thumb on a situation like this is that the resource library should be split out of the parent formula if all three criteria are met:

  • The library on its own satisfies the criteria for inclusion as a new formula
  • The versioning of the library differs from that of the parent formula
  • The upstream release processes align such that we don't have to hold back one formula for the other
    • Upstream could release updates in lockstep for both formulae, and/or
    • Upstream is careful about backward/forward compatibility and when/how to introduce breaking changes

So far this case seems to satisfy at least the first two points at a glance.

There's always exceptions, and these are just my personal thoughts.

Also might be worth seeing what other distros are doing - https://repology.org/project/falcosecurity-libs/versions, https://repology.org/project/sysdig/versions.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Feb 26, 2025
@daeho-ro daeho-ro removed the stale No recent activity label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` lua Lua use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants