i686-elf-grub 2.06, x86_64-elf-grub 2.06 (new formulae)

[rabarbra]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[github-actions]

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

[rabarbra]

The CI pipeline is failing because of CI/Linux job.
The CI/Linux is failing because of this:

==> FAILED
Full audit --formula i686-elf-grub --online --new output
  i686-elf-grub
    * The homepage URL https://www.gnu.org/software/grub/ is not reachable
    * Binaries built for a non-native architecture were installed into i686-elf-grub's prefix.
      The offending files are:
        /home/linuxbrew/.linuxbrew/Cellar/i686-elf-grub/2.06/lib/i686-elf/grub/i386-pc/i686-elf-boot.image	(i386)
        /home/linuxbrew/.linuxbrew/Cellar/i686-elf-grub/2.06/lib/i686-elf/grub/i386-pc/i686-elf-boot_hybrid.image	(i386)
        /home/linuxbrew/.linuxbrew/Cellar/i686-elf-grub/2.06/lib/i686-elf/grub/i386-pc/i686-elf-cdboot.image	(i386)
        /home/linuxbrew/.linuxbrew/Cellar/i686-elf-grub/2.06/lib/i686-elf/grub/i386-pc/i686-elf-diskboot.image	(i386)
        /home/linuxbrew/.linuxbrew/Cellar/i686-elf-grub/2.06/lib/i686-elf/grub/i386-pc/i686-elf-kernel.exec	(i386)
        /home/linuxbrew/.linuxbrew/Cellar/i686-elf-grub/2.06/lib/i686-elf/grub/i386-pc/i686-elf-lnxboot.image	(i386)
        /home/linuxbrew/.linuxbrew/Cellar/i686-elf-grub/2.06/lib/i686-elf/grub/i386-pc/i686-elf-lzma_decompress.image	(i386)
        /home/linuxbrew/.linuxbrew/Cellar/i686-elf-grub/2.06/lib/i686-elf/grub/i386-pc/i686-elf-pxeboot.image	(i386)
        /home/linuxbrew/.linuxbrew/Cellar/i686-elf-grub/2.06/lib/i686-elf/grub/i386-pc/kernel.img	(i386)
  Error: 2 problems in 1 formula detected.

The CI pipeline is showing failures in the Linux job due to two issues:

1. Homepage unreachable: This appears to be a false positive as https://www.gnu.org/software/grub/ is accessible and passes the check in the macOS jobs.

2. Non-native architecture binaries: The audit is flagging i386 binaries in the package. However, this is expected and necessary behavior for this formula as it's a cross-compiler toolchain specifically designed to produce i386/i686 binaries. And brew audit is again passing macOS jobs, while prefix still contains non-native binaries.

Would appreciate guidance on how to best handle these CI checks.

[botantony]

This is a common problem with gnu.org/nongnu.org homepages (#206757). Try to use savannah.gnu.org if it has a homepage for these programs

[botantony]

also can you please add at least one mirror for each formula? and why do you split one program into 2 formulae?

[rabarbra]

Thank you for quick reaction!

GRUB tools are used to create and work with bootable images for specific architectures.

Tools like grub-mkrescue, grub-mkimage, and grub-mkstandalone embed architecture-specific software during their compilation process. This is controlled through target-specific variables:

TARGET_OBJCOPY=#{target}-objcopy  
TARGET_STRIP=#{target}-strip
TARGET_NM=#{target}-nm
TARGET_RANLIB=#{target}-ranlib

I have these in my formulas.

There is no universal version of these tools that can produce bootable images for any architecture. Instead:

• To create bootable images for i686 (32-bit) systems, you need i686-elf-grub-mkrescue compiled with tools for i686 architecture
• To create bootable images for x86_64 (64-bit) systems, you need x86_64-elf-grub-mkrescue

When installing GRUB, you typically only install the tools for the specific architecture you're working with. This approach leverages the cross-compiler toolchains already available in Homebrew (i686-elf-binutils and x86_64-elf-binutils for example), allowing you to build boot images targeted at specific architectures regardless of your host system.

I will change homepage to https://savannah.gnu.org/projects/grub later today and add this mirror: https://mirrors.ocf.berkeley.edu/gnu/grub/grub-2.06.tar.xz.

But formulas will still not pass the Linux CI job because of brew audit detecting non-native binaries. Question is if we can omit this check. And why does it pass all the MacOs CIs, while there are still non-native binaries in formula's prefix. Why this test is different for MacOs and Linux?

[botantony]

macOS CI is kinda strange (maybe because macOS uses Clang vs. Linux uses GCC) but I can say for sure that Homebrew would never ever accept non-native binaries

[rabarbra]

But these binaries are not executables, they are images for specific architectures, used by GRUB tools to work with images and GRUB itself compiled for these architectures, needed to create images.

Problem is how brew audit defines if it is executable binary in Linux. It supposed to skip not executables (see this line: https://github.com/Homebrew/brew/blob/b4dbbf19a21352dd5ed0748e32e6c3b7f15e800c/Library/Homebrew/extend/os/linux/keg_relocate.rb#L76).

It happens like this in MacOs: ruby-macho gem just returns ":dunno" for these files (https://github.com/Homebrew/brew/blob/master/Library/Homebrew/os/mac/mach.rb).

But for Linux the test is following: https://github.com/Homebrew/brew/blob/b4dbbf19a21352dd5ed0748e32e6c3b7f15e800c/Library/Homebrew/os/linux/elf.rb#L91.
It only tests if it is elf file with ET_EXEC flag in ELF header's e_type field. But file like this is not necessary executable. GRUB's make install gives only read permissions for these files, not execute.

[gromgit]

Try adding lib/i686-elf/** to audit_exceptions/mismatched_binary_allowlist.json.

[botantony]

I still don't understand why we have to split this formula. Why not build 2 different targets in one formula?

[rabarbra]

I still don't understand why we have to split this formula. Why not build 2 different targets in one formula?

You can specify only single target for configure script, not multiple.
But my configuration for x86_64 is actually wrong: I forgot to change --wich-platform value to efi from pc. I'll also fix this.