Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect padding being calculated... #5

Open
redRock14 opened this issue Dec 23, 2024 · 1 comment
Open

Incorrect padding being calculated... #5

redRock14 opened this issue Dec 23, 2024 · 1 comment

Comments

@redRock14
Copy link
Contributor

redRock14 commented Dec 23, 2024

First, thank you for putting this project together. It is awesome - it generates baseplates very nicely and I highly appreciate you taking the time to offer this. I have a couple of issues...

I have a Prusa printer. The print volume is 250 x 210 x 220.

I am trying to create a gridfinity base for drawer in a toolbox with the following dimensions: 309mm wide by 495mm deep. I've selected Center Justify and after the "Calculate Layout" button is pressed, I get 6 scad files. The first problem I get is the same one previously reported where the objects being calculated are too big for my build plate.

So, to get around the issue, I changed the print plate dimensions to 250 x 200 and this time each file fit the build plate. PrusaSlicer can accomodate all pieces. HOWEVER, this is where I found a bug in the way the "middle" pieces get calculated.

We have this:

image

Now, open the 5x4(7.5 mm Left).scad file and you will notice the coordinate is including the padding for top and bottom. This file should only have padding on the left. This file by the way, is the one that represents the area in purple below:

image

The script generated sets the following constants:

image

The problem is the distancey constant: It is including the padding.

If you make this 168 and render the object once again in OpenSCAD, then the dimensions are correct. And by this I mean, there is only padding on the left side of the model. The top, right, and bottom sides should not have padding.

The code looks like it is not taking this into account when calculating a model that fits inside the bounds of the set dimensions.

redRock14 added a commit to redRock14/Gridfinity that referenced this issue Jan 10, 2025
This is a fix for Issue HopperDropper#5 in the "Issues" tab of the project.  Also added jinja2 to the requirements.txt file.
@HopperDropper
Copy link
Owner

Thanks redRock14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants