Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing volunteer #1

Open
markcampanelli opened this issue May 11, 2024 · 6 comments
Open

Testing volunteer #1

markcampanelli opened this issue May 11, 2024 · 6 comments

Comments

@markcampanelli
Copy link

@HugoMVale Thanks for tackling new Python bindings to ODRDPACK95. I make great use of ODR with the implicit-equation formulation. I also have a use case for bounded parameters. I would be happy to test out https://github.com/markcampanelli/pvfit using these Python bindings. Please ping me here when you think things are ready for such testing.

@HugoMVale
Copy link
Owner

@markcampanelli, thanks a lot for the offer. I hope a first draft in June. Keep you posted.

@RobbieMackenzie
Copy link

Great that you're doing this Hugo, I was thinking of rewriting ODRPACK95 in Julia a while back but I didn't have sufficient skill. Python bindings for ODRPACK95 is a great addition. Thanks.

@HugoMVale
Copy link
Owner

Thanks for the encouragement, @RobbieMackenzie.

My personal opinion is that mankind does not have the luxury of having enough people with enough time to afford a translation of a given library in every language. I just can't imagine having - and maintaining - a version of cvode (just to mention a well-known library) in C, Fortran, Julia, Rust, Go, Zig, Mojo, Carbon, ...

I think the odrpack source code is now in a presentable, modern state that can be understood, fixed, and improved by anyone that would be able to do do in any other language. Now, one should definitely work on bindings, as you say!

My hope/understanding is that the scipy team could take care of the python bindings, since they already have bindings for the "old" ODRPACK. Additionally, one could also do an interface for Julia. That would be really cool.!I just saw a nice example for PRIMA.

@HugoMVale
Copy link
Owner

@markcampanelli and @RobbieMackenzie : In case you are still interested, I took some time over Xmas to work on the Python bindings. The project is hosted in an separate repo and a preliminary version is already available in PyPI. If you find the time to test it, I would very much appreciate your feedback.

https://github.com/HugoMVale/odrpack-python
https://pypi.org/project/odrpack/

@RobbieMackenzie
Copy link

Hi @HugoMVale , nice work, I've had a go with the example code from the README, and it worked perfectly. I tried it out on Windows 11, and also on Ubuntu 20.04 (focal) running under WSL. The Python versions were 3.11 and 3.13 respectively, and when I tried to install it for 3.8 it failed appropriately.

I'll test it with some more difficult problems later. I had to learn the rudiments of Fortran when I first started using ODRPACK95; these Python bindings will make it so much easier for new users. Thanks for your hard work :)

@HugoMVale
Copy link
Owner

Hi @RobbieMackenzie, thanks a lot for taking the time to check it on multiple python versions and OSs! I'm glad to hear it worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants