This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LSDV-1476: Fix selected=true for Taxonomy #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First try, not fully working. Now `<Choice selected="true">` will work inside Taxonomy as well.
- fix example for classifications - fix typo in FF link - add list of all Taxonomy and Choices related FFs
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1239 +/- ##
==========================================
+ Coverage 64.97% 65.02% +0.04%
==========================================
Files 439 439
Lines 27464 27490 +26
Branches 7176 7182 +6
==========================================
+ Hits 17846 17874 +28
+ Misses 9618 9616 -2
☔ View full report in Codecov by Sentry. |
11 tasks
juliosgarbi
reviewed
Jun 30, 2023
juliosgarbi
approved these changes
Jun 30, 2023
Not the best way to do it anyway
Gondragos
approved these changes
Jun 30, 2023
|
/git merge master
|
|
/git merge master
|
Children should be init before other processes like setDefaultValues()
This case can happen during store init in Label Stream, task will be loaded later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
<Choice selected="true">will work inside Taxonomy as well.PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
Choicetag hasselectedbool attribute to define preselected options in config. But this didn't work forChoices insideTaxonomy.What does this fix?
Adds
preselectedValuestoTaxonomy, fix init ofChoices inside Shared Store in order for them to have proper values.What is the new behavior?
"Usual" value is preselected in new annotations in configs like this:
What is the current behavior?
Choices in Taxonomy can't be preselected.
What libraries were added/updated?
none
Does this change affect performance?
updateValue()is called for every Choice in Taxonomy at initialization, so it may affect performance, but slightly.Does this change affect security?
nope
What alternative approaches were there?
preselectedValuesare current standard for such things, so no alternatives here.For
Choicevalue simpler approach can be used to getvalue/aliasdirectly, not via getter, but it requires duplication of value retrieval logic (array/string).What feature flags were used to cover this change?
ff_dev_2100_preselected_choices_250422_shortto enable preselected choicesfflag_fix_front_dev_3617_taxonomy_memory_leaks_fixmade it harderDoes this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Taxonomy, Dynamic Choices