Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LSDV-4620-4: Optimize outliner region tree rendering #1518

Merged
merged 14 commits into from
Aug 2, 2023

Conversation

Gondragos
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

There is a problem with the responsiveness of the interface with a large number of regions.

What does this fix?

  1. Improve performance
  2. Fix functionality under fflag_feat_dev_2755_regions_list_grouped_by_labels_with_ordered_collapse_short
  3. Fix grouping selector stop working after switching between annotations

Does this change affect performance?

Definitely!

What feature flags were used to cover this change?

fflag_feat_front_lsdv_4620_outliner_optimization_310723_short

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Region tree, Outliner

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch coverage: 87.83% and project coverage change: +0.92% 🎉

Comparison is base (096576f) 67.22% compared to head (97197be) 68.14%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1518      +/-   ##
==========================================
+ Coverage   67.22%   68.14%   +0.92%     
==========================================
  Files         439      439              
  Lines       28035    28083      +48     
  Branches     7415     7433      +18     
==========================================
+ Hits        18847    19138     +291     
+ Misses       7930     7729     -201     
+ Partials     1258     1216      -42     
Files Changed Coverage Δ
src/components/SidePanels/PanelBase.tsx 97.54% <ø> (ø)
...mponents/SidePanels/OutlinerPanel/OutlinerTree.tsx 76.89% <85.24%> (+7.19%) ⬆️
...ponents/SidePanels/OutlinerPanel/OutlinerPanel.tsx 90.24% <100.00%> (+12.46%) ⬆️
...mponents/SidePanels/OutlinerPanel/ViewControls.tsx 97.26% <100.00%> (+5.59%) ⬆️
src/components/SidePanels/TabPanels/Tabs.tsx 24.27% <100.00%> (+19.36%) ⬆️
src/utils/feature-flags.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gondragos Gondragos force-pushed the fb-lsdv-4620-4/outliner-fixes branch from abc08d5 to 678413a Compare July 31, 2023 21:55
@Gondragos Gondragos enabled auto-merge (squash) August 2, 2023 21:25
@Gondragos Gondragos merged commit 99dfe7c into master Aug 2, 2023
11 of 13 checks passed
@Gondragos Gondragos deleted the fb-lsdv-4620-4/outliner-fixes branch August 2, 2023 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants