Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LSDV-5523: Check tag has context scroll true to show the toggle #1527

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

Travis1282
Copy link
Contributor

@Travis1282 Travis1282 commented Aug 15, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@bmartel bmartel changed the title Fix: LSDV-5523: Check tag has context scroll true to show the toggle fix: LSDV-5523: Check tag has context scroll true to show the toggle Aug 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.02% ⚠️

Comparison is base (999a946) 68.04% compared to head (e8e328c) 68.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
- Coverage   68.04%   68.02%   -0.02%     
==========================================
  Files         442      442              
  Lines       28231    28233       +2     
  Branches     7481     7483       +2     
==========================================
- Hits        19209    19205       -4     
- Misses       7790     7794       +4     
- Partials     1232     1234       +2     
Files Changed Coverage Δ
src/tags/object/Paragraphs/HtxParagraphs.js 78.57% <83.33%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Travis1282 Travis1282 merged commit 3f8c90d into master Aug 24, 2023
14 checks passed
@Travis1282 Travis1282 deleted the fb-lsdv-5523/context-controls-only-contextscroll branch August 24, 2023 21:42
bmartel pushed a commit that referenced this pull request Aug 28, 2023
…1527)

check tag has context scroll true to show the toggle
bmartel added a commit that referenced this pull request Aug 28, 2023
…the toggle, secure secret key (#1548)

fix: LSDV-5523: Check tag has context scroll true to show the toggle (#1527)

check tag has context scroll true to show the toggle

Co-authored-by: Travis Clark <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants