Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LSDV-5544: Fix RichText tag in non-Chromium browsers #1540

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

Gondragos
Copy link
Contributor

The fix #1516 broke RichText functionality under the flag fflag_feat_front_lsdv_4620_richtext_opimization_060423_short.
This PR should fix it.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

What libraries were added/updated?

N/A

Does this change affect performance?

Nope

Does this change affect security?

Nope

What alternative approaches were there?

N/A

What feature flags were used to cover this change?

fflag_feat_front_lsdv_4620_richtext_opimization_060423_short

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

RichText

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01% ⚠️

Comparison is base (41ae765) 65.20% compared to head (da307c0) 65.20%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1540      +/-   ##
==========================================
- Coverage   65.20%   65.20%   -0.01%     
==========================================
  Files         442      442              
  Lines       28233    28230       -3     
  Branches     7377     7376       -1     
==========================================
- Hits        18410    18407       -3     
  Misses       9823     9823              
Files Changed Coverage Δ
src/tags/object/AudioUltra/model.js 83.91% <ø> (ø)
src/tags/object/RichText/domManager.ts 89.09% <ø> (-0.03%) ⬇️
src/tags/visual/View.js 92.30% <ø> (ø)
src/utils/feature-flags.ts 100.00% <ø> (ø)
src/mixins/Visibility.js 77.77% <50.00%> (-0.61%) ⬇️
src/regions/Result.js 79.47% <100.00%> (ø)
src/tags/control/Choices.js 74.39% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gondragos Gondragos enabled auto-merge (squash) August 28, 2023 12:59
@Gondragos Gondragos merged commit d29f385 into master Aug 28, 2023
14 of 15 checks passed
@Gondragos Gondragos deleted the fb-lsdv-5544 branch August 28, 2023 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants