This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
feat: OPTIC-2: Save draft on leave #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmartel
reviewed
Aug 31, 2023
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
bmartel
approved these changes
Sep 5, 2023
bmartel
reviewed
Sep 5, 2023
|
|
||
| return self.store.submitDraft(self, params).then(self.onDraftSaved); | ||
| return self.store.submitDraft(self, params).then((res) => { | ||
| self.onDraftSaved(res); |
There was a problem hiding this comment.
Do any other callers of saveDraft require that the onDraftSaved callback be the return of the function promise? I noticed we are changing to use the raw result instead so that we can get access to this information, I'm wondering if that might break other usages. Do we know for certain the usages expectation of this return?
There was a problem hiding this comment.
I'm going to approve this with the caveat that we may have to consider this depending on whether any integration tests fail (and subsequently answer this question for us 😅).
|
/git merge master
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
lost drafts during timeout, no user feedback
What does this fix?
(if this is a bug fix)
What is the new behavior?
saved drafts when user navigates away from annotation page, gives toast feedback
What is the current behavior?
lost drafts during timeout, no user feedback
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)