Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

feat: LEAP-187: Skip Video to region start on select #1563

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Sep 18, 2023

Works only on select from Outliner.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Frontend

Describe the reason for change

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Works only on select from Outliner.
@github-actions github-actions bot added the feat label Sep 18, 2023
@hlomzik hlomzik changed the title feat: LEAP-187: Seek Video to region start on select feat: LEAP-187: Skip Video to region start on select Sep 18, 2023
src/utils/feature-flags.ts Outdated Show resolved Hide resolved
@hlomzik hlomzik enabled auto-merge (squash) September 19, 2023 10:23
@hlomzik hlomzik merged commit 55e11d4 into master Sep 19, 2023
12 of 15 checks passed
@hlomzik hlomzik deleted the fb-leap-187/seek_video_on_select branch September 19, 2023 11:55
@sentry-io
Copy link

sentry-io bot commented Sep 28, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'frame') <object>.onSelectInOutliner(src/regions/VideoRe... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants