Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-208: Make Labeling Settings clickable #1566

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Sep 20, 2023

Expand clickable area by using label tag.

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

This change affects (describe how if yes)

  • Performance
  • Security
  • UX — easier and more obvious to change settings

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e (codecept)
  • integration (cypress)
  • unit (jest)

Expand clickable area by using `label` tag.
@hlomzik
Copy link
Collaborator Author

hlomzik commented Sep 22, 2023

/git merge master

Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-208/clickable-settings (d36027e)

Workflow run

Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and simple, i like it!

@hlomzik hlomzik marked this pull request as draft November 14, 2023 16:07
@hlomzik hlomzik marked this pull request as ready for review November 14, 2023 16:08
@hlomzik
Copy link
Collaborator Author

hlomzik commented Nov 14, 2023

/git merge master

Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-208/clickable-settings (0e7a5ad)

Workflow run

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4891f39) 67.91% compared to head (0e7a5ad) 64.51%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1566      +/-   ##
==========================================
- Coverage   67.91%   64.51%   -3.40%     
==========================================
  Files         443      443              
  Lines       28651    28651              
  Branches     7614     7503     -111     
==========================================
- Hits        19458    18485     -973     
- Misses       7923    10166    +2243     
+ Partials     1270        0    -1270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hlomzik hlomzik merged commit c6295ea into master Nov 16, 2023
15 of 16 checks passed
@hlomzik hlomzik deleted the fb-leap-208/clickable-settings branch November 16, 2023 16:16
MasherJames pushed a commit to HelloPareto/label-studio-frontend that referenced this pull request Feb 29, 2024
Expand clickable area by using `label` tag.

Co-authored-by: hlomzik <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants