This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-368: Don't add hidden and locked to undo history
#1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very simple fix. But there is a new UX problem them: if you undo/redo actions done to hidden regions you see no changes on the screen, previously region became visible at some point and them undo to actual actions.
This was referenced Dec 13, 2023
Gondragos
approved these changes
Dec 20, 2023
yyassi-heartex
approved these changes
Dec 20, 2023
|
/git merge master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
- Coverage 68.28% 64.54% -3.75%
==========================================
Files 443 443
Lines 28690 28690
Branches 7630 7519 -111
==========================================
- Hits 19591 18517 -1074
- Misses 7847 10173 +2326
+ Partials 1252 0 -1252 ☔ View full report in Codecov by Sentry. |
hlomzik
changed the title
hidden and locked to undo history
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
…Signal#1641) * fix: LEAP-368: Don't add visibility to undo history Very simple fix. But there is a new UX problem them: if you undo/redo actions done to hidden regions you see no changes on the screen, previously region became visible at some point and them undo to actual actions. * Also do the same with `locked` property --------- Co-authored-by: hlomzik <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple fix. But there is a new UX problem them: if you undo/redo actions done to hidden regions you see no changes on the screen, previously region became visible at some point and only then undo went through actual actions.
PR fulfills these requirements
What feature flags were used to cover this change?
none — maybe we need this to cover UX change
What alternative approaches were there?
This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?