This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-461: Fix displaying conditions for comments tab #1650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments tab disappeared on the screen resizing.
This is a fix for conditions for filtering set of tabs in sidebar in two different modes of displaying this sidebar.
PR fulfills these requirements
Describe the reason for change
There are two approaches for rendering tabs with the actual set of feature flags.
The first problem was that this 2 approaches used different conditions. So that we had wrong set of available tabs.
The second problem was in the way we throw the conditions from the interface settings through the bunch of levels of components. Semantically it was wrong according to naming so it was a mess.
This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
Sidebar
,Comments
,Interfaces