This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: OPTIC-354: Comment draft preserved between annotations #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 28, 2023
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1652 +/- ##
=======================================
Coverage 68.27% 68.28%
=======================================
Files 443 443
Lines 28690 28690
Branches 7633 7630 -3
=======================================
+ Hits 19589 19591 +2
+ Misses 7849 7846 -3
- Partials 1252 1253 +1 ☔ View full report in Codecov by Sentry. |
Travis1282
force-pushed
the
fb-optic-354/comment-draft-preserved-between-annotations
branch
from
1300f73
to
1e63e53
Compare
hlomzik
previously requested changes
Dec 28, 2023
hlomzik
approved these changes
Jan 3, 2024
nikitabelonogov
force-pushed
the
fb-optic-354/comment-draft-preserved-between-annotations
branch
from
264385c
to
ffa585e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s' of github.com:heartexlabs/label-studio-frontend into fb-optic-354/comment-draft-preserved-between-annotations
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Travis1282
deleted the
fb-optic-354/comment-draft-preserved-between-annotations
branch
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
…nal#1652) * fix: optic-354: coment draft preserved between annotations * fix typo, remove console * retest * Update src/stores/Comment/CommentStore.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update src/components/Comments/Comments.tsx Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Nikita Belonogov <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when user starts replying on one comment, and than switch to another annotation, comment entered (but not submitted) on the first annotation is not removed from the comment filed, and can be accidentally sent. This fix persists drafts between annotations on a task by putting unsubmitted draft comments in a map using annotation id as a key for each draft comment.
OPTIC-354