diff --git a/src/library/validate.py b/src/library/validate.py index cca0f28..71f046d 100644 --- a/src/library/validate.py +++ b/src/library/validate.py @@ -33,7 +33,7 @@ def process_hash_list(document_datasets): file_schema_valid = file_data[6] publisher_black_flag = file_data[7] is not None - if not file_schema_valid and downloaded > ( + if file_schema_valid is False and downloaded > ( now - timedelta(hours=config["VALIDATION"]["SAFETY_CHECK_PERIOD"]) ): logger.info( @@ -43,7 +43,7 @@ def process_hash_list(document_datasets): ) continue - if not file_schema_valid and publisher_black_flag: + if file_schema_valid is False and publisher_black_flag is True: logger.info( "Skipping Schema Invalid file for Full Validation since publisher: " f"{publisher} is black flagged for hash: {file_hash} and id: {file_id}" @@ -104,7 +104,7 @@ def process_hash_list(document_datasets): ) try: body = schema_response.json() - if body["valid"] or not body["valid"]: + if body["valid"] is True or body["valid"] is False: db.updateDocumentSchemaValidationStatus(conn, file_id, body["valid"]) file_schema_valid = body["valid"] else: @@ -115,7 +115,7 @@ def process_hash_list(document_datasets): ) continue - if not file_schema_valid and downloaded > ( + if file_schema_valid is False and downloaded > ( now - timedelta(hours=config["VALIDATION"]["SAFETY_CHECK_PERIOD"]) ): logger.info( @@ -125,7 +125,7 @@ def process_hash_list(document_datasets): ) continue - if not file_schema_valid and publisher_black_flag: + if file_schema_valid is False and publisher_black_flag is True: logger.info( f"Skipping Schema Invalid file for Full Validation since publisher: {publisher} " f"is flagged for hash: {file_hash} and id: {file_id}" @@ -141,7 +141,7 @@ def process_hash_list(document_datasets): full_url = config["VALIDATION"]["FULL_VALIDATION_URL"] # only need meta=true for invalid files to "clean" them later - if not file_schema_valid: + if file_schema_valid is False: full_url += "?meta=true" full_response = requests.post( full_url,