From db0b5dbf153925d24bc7137500ac677f65df0b46 Mon Sep 17 00:00:00 2001
From: Chris Arridge <chris.arridge@opendataservices.coop>
Date: Wed, 22 Jan 2025 14:25:37 +0000
Subject: [PATCH 1/2] fix: Improved fix for XML URL links on report page

Changes XML URL link on report page from <RouterLink> to a standard
HTML anchor.
---
 src/pages/ReportPage.vue | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/pages/ReportPage.vue b/src/pages/ReportPage.vue
index de512433..00bf2332 100644
--- a/src/pages/ReportPage.vue
+++ b/src/pages/ReportPage.vue
@@ -135,9 +135,7 @@
         <RouterLink :to="`/organisation/${organisation.name}`">{{ organisation.title }}</RouterLink>
         -
       </template>
-      <RouterLink v-if="document" :href="document.url" :external="true">
-        {{ getDocumentFileName(document) }}
-      </RouterLink>
+      <a v-if="document" :href="document.url">{{ getDocumentFileName(document) }}</a>
       <div v-if="dataset && isTestFile">{{ dataset.filename }}</div>
     </h2>
     <DocumentInfo v-if="dataset && dataset.report" :document="document" :report="dataset.report" />

From 4dbd31338af1407370bafd35fe0e0aeb9a564fa9 Mon Sep 17 00:00:00 2001
From: Chris Arridge <chris.arridge@opendataservices.coop>
Date: Wed, 22 Jan 2025 15:05:16 +0000
Subject: [PATCH 2/2] test: add test to check that XML urls are correctly
 presented

---
 cypress/integration/validationReport.spec.js | 10 ++++++++++
 src/pages/ReportPage.vue                     |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/cypress/integration/validationReport.spec.js b/cypress/integration/validationReport.spec.js
index 646e1e98..e5c806b2 100644
--- a/cypress/integration/validationReport.spec.js
+++ b/cypress/integration/validationReport.spec.js
@@ -139,4 +139,14 @@ describe("The Validation Report page", () => {
       expect(loc.search).to.eq("?id=XM-TEST-VALIDATION-01-B");
     });
   });
+
+  it("opens the validation report page and presents the correct XML URLs in the document link", () => {
+    cy.fixture("validationReport01ares");
+    cy.intercept("**/existing?name=ares-activities", {
+      fixture: "validationReport01ares.json",
+    }).as("validation");
+    cy.visit("/report/ares-activities?id=BE-BCE_KBO-0546740696-PG2017-2021_CD");
+    cy.get("[data-cy='document-url-anchor']").should("have.attr", "href", "https://aidstream.s3.us-west-2.amazonaws.com/xml/ares-activities.xml");
+    cy.get("[data-cy='document-url-anchor']").should("have.text", "ares-activities.xml");
+  });
 });
diff --git a/src/pages/ReportPage.vue b/src/pages/ReportPage.vue
index 00bf2332..9c0f25df 100644
--- a/src/pages/ReportPage.vue
+++ b/src/pages/ReportPage.vue
@@ -135,7 +135,7 @@
         <RouterLink :to="`/organisation/${organisation.name}`">{{ organisation.title }}</RouterLink>
         -
       </template>
-      <a v-if="document" :href="document.url">{{ getDocumentFileName(document) }}</a>
+      <a data-cy="document-url-anchor" v-if="document" :href="document.url">{{ getDocumentFileName(document) }}</a>
       <div v-if="dataset && isTestFile">{{ dataset.filename }}</div>
     </h2>
     <DocumentInfo v-if="dataset && dataset.report" :document="document" :report="dataset.report" />