Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to include RFE in pipeline! #106

Open
michele2198 opened this issue Mar 23, 2022 · 3 comments
Open

unable to include RFE in pipeline! #106

michele2198 opened this issue Mar 23, 2022 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@michele2198
Copy link

I apologize but I am new to Julia. i am trying to perform recursive feature elimination (RFE) in a pipeline:

ada = Adaboost()
disc = CatNumDiscriminator()
pt = PrunedTree()
rfe=SKPreprocessor("RFE",Dict(:estimator=>ada));

pvote = disc |> ((catf |> ohe) + (numf|>rfe)) |> pt

but always got the same error TypeError("init() missing 1 required positional argument: 'estimator'") although it seems to me that the estimator has been provided. How should RFE be used?

Than you in advance

@ppalmes
Copy link
Collaborator

ppalmes commented Mar 24, 2022

it's a bug. RFE is not part of the unit-testing and I only tested with the popular algos in sklearn. i will try to fix it. the issue is that the algo uses another python object in its argument so i need to unwrap the python object inside the julia structure. thanks for raising this issue. by the way, Adaboost() is a julia algo so the better way is to use the sklearn adaboost using skoperator("AdaBoostClassifier") or skoperator("AdaBoostRegressor") and use this estimator to the RFE. i'll update here if I fix the issue.

@ppalmes ppalmes self-assigned this Mar 24, 2022
@ppalmes ppalmes added the bug Something isn't working label Mar 24, 2022
@ppalmes
Copy link
Collaborator

ppalmes commented Mar 24, 2022

you can also read the implementation and perhaps help fix it ;).

@michele2198
Copy link
Author

Thank you for answer and considering this work, I am in a project where we aim at comparing many combination of feature reduction + ML combinations so it would help us a lot. Kindest regards

@ppalmes ppalmes added help wanted Extra attention is needed and removed bug Something isn't working labels Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants