Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All operators should support export_to_sklearn_pipeline #544

Open
shinnar opened this issue Dec 3, 2020 · 1 comment
Open

All operators should support export_to_sklearn_pipeline #544

shinnar opened this issue Dec 3, 2020 · 1 comment
Assignees
@kiran-kate

Comments

@shinnar
Copy link
Member

shinnar commented Dec 3, 2020

currently, only pipelines (BasePipeline and its children) implement this.
It should be implemented for all Operators
shinnar added a commit to shinnar/lale that referenced this issue Dec 3, 2020
@shinnar
Add an assertion in topk_voting_classifier's get_pipeline implementation
d001492 
to verify that the result is a Pipeline before calling export_to_sklearn_pipeline on it.

This assertion should be removed once Operator supports get_pipeline, as per IBM#544
shinnar added a commit that referenced this issue Dec 3, 2020
@shinnar
Add an assertion in topk_voting_classifier's get_pipeline implementation
c83beb1 
to verify that the result is a Pipeline before calling export_to_sklearn_pipeline on it.

This assertion should be removed once Operator supports get_pipeline, as per #544
@shinnar
Copy link
Member Author

shinnar commented Dec 3, 2020

we plan to create a new export_to_sklearn function on Operator. export_to_sklearn_pipeline will just call it and be deprecated / removed subject to compatibility constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kiran-kate kiran-kate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shinnar @kiran-kate