Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newest Hyperopt #879

Open
hirzel opened this issue Nov 17, 2021 · 1 comment
Open

Update to newest Hyperopt #879

hirzel opened this issue Nov 17, 2021 · 1 comment

Comments

@hirzel
Copy link
Member

hirzel commented Nov 17, 2021

Hyperopt 0.2.6 was released on November 15: https://pypi.org/project/hyperopt/0.2.6/

Unfortunately, it breaks many Lale tests: https://github.com/IBM/lale/actions/runs/1467468837

For example, the failures include some very basic tests such as:

  • test.test_core_transformers.TestFeaturePreprocessing.test_MinMaxScaler
  • test.test_core_transformers.TestFeaturePreprocessing.test_PCA
  • test.test_core_transformers.TestConcatFeatures.test_concat_with_hyperopt

So for now, we limit the Hyperopt version to <=0.2.5: 24db058

We should try to update to the latest (in fact, if we are lucky, Hyperopt 0.2.7 fixes the problem).

@hirzel
Copy link
Member Author

hirzel commented Nov 17, 2021

Update: PR #880 shows that Hyperopt 0.2.7 doesn't just magically fix the problem, so this will require more debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant