Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traces with spec-checking error blocks may contain absolute (also non-normalized) paths #410

Open
starpit opened this issue Feb 12, 2025 · 0 comments
Labels
bug Something isn't working interpreter UI

Comments

@starpit
Copy link
Member

starpit commented Feb 12, 2025

Describe the bug
Perhaps we should use relative (and normalized) paths here? e.g.

msg: |-
  Type errors during spec checking:
  /Users/starpit/git/prompt-declaration-language/pdl-live-react/demos/../demos/error.pdl:3 - Missing required field: answers
  /Users/starpit/git/prompt-declaration-language/pdl-live-react/demos/../demos/error.pdl:3 - Missing required field: questions
  /Users/starpit/git/prompt-declaration-language/pdl-live-react/demos/../demos/error.pdl:3 - Field not allowed: source_code
  /Users/starpit/git/prompt-declaration-language/pdl-live-react/demos/../demos/error.pdl:3 - Field not allowed: repo_info

To Reproduce
See the paths above

Expected behavior
Absolute paths are long, and also mean that traces preserve potentially sensitive information (in the absolute path).

Screenshots
n/a

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. Chrome, Safari]
  • Version [e.g. 22]

Additional context
n/a

@starpit starpit added the bug Something isn't working label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working interpreter UI
Projects
None yet
Development

No branches or pull requests

2 participants