Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of files which have just ALTER statements in them #18

Open
worksofliam opened this issue Nov 17, 2023 · 2 comments
Open
Labels
base Belongs in the base enhancement New feature or request

Comments

@worksofliam
Copy link
Member

Since we recommend alter files should be in a separate file, we need a way to have a target which doesn't result in an object (for files with ALTER) statements

@edmundreinhardt
Copy link
Member

I thought that the ALTER statements would be included in the same file as CREATE OR REPLACE TABLE. does that not work?

@worksofliam
Copy link
Member Author

@edmundreinhardt Right now, no. ALTER statements can create circular deps very easily.

For example, two files:

  1. CREATE TABLE DEPARTMENT, with an ALTER which adds a reference to table EMPLOYEE
  2. CREATE TABLE EMPLOYEE with an ALTER which adds a reference to table DEPARTMENT

This circular dep is bad. Moving those alters to separate files will allow us to resolve this issue.

@worksofliam worksofliam changed the title Better handle files which have just ALTER statements in them Improve handling of files which have just ALTER statements in them Nov 17, 2023
@worksofliam worksofliam added the base Belongs in the base label Jan 17, 2024
@worksofliam worksofliam added the enhancement New feature or request label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base Belongs in the base enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants