diff --git a/.github/workflows/pr-18.yaml b/.github/workflows/pr-18.yaml index f3ffa3a2e2494..04b4b0ff35e0c 100644 --- a/.github/workflows/pr-18.yaml +++ b/.github/workflows/pr-18.yaml @@ -32,7 +32,7 @@ jobs: run: | gh pr edit "$url" --add-assignee rycks --add-reviewer rycks gh pr merge "$url" --merge --auto - + continue-on-error: true - name: Assign reviewer method 2 env: diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 5a41c986098cd..97f218fce4d50 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -3,8 +3,7 @@ on: workflow_dispatch: pull_request: types: [opened, reopened, synchronize] - branches: - - "18.0" + push: env: ENVGHT: ${{ secrets.GITHUB_TOKEN }} diff --git a/htdocs/comm/contact.php b/htdocs/comm/contact.php index 19be738a50efd..11ba439f86ba3 100644 --- a/htdocs/comm/contact.php +++ b/htdocs/comm/contact.php @@ -37,7 +37,7 @@ $sortorder = "ASC"; } if (!$sortfield) { - $sortfield = "p.name"; + $sortfield = "p.lastname"; } if ($page < 0) { $page = 0; @@ -81,7 +81,7 @@ */ $sql = "SELECT s.rowid, s.nom as name, st.libelle as stcomm"; -$sql .= ", p.rowid as cidp, p.name, p.firstname, p.email, p.phone"; +$sql .= ", p.rowid as cidp, p.lastname, p.firstname, p.email, p.phone"; $sql .= " FROM ".MAIN_DB_PREFIX."c_stcomm as st,"; if (empty($user->rights->societe->client->voir) && !$socid) { $sql .= " ".MAIN_DB_PREFIX."societe_commerciaux as sc,"; @@ -106,7 +106,7 @@ $sql .= " AND s.rowid = ".((int) $socid); } if (!empty($search_lastname)) { - $sql .= " AND p.name LIKE '%".$db->escape($search_lastname)."%'"; + $sql .= " AND p.lastname LIKE '%".$db->escape($search_lastname)."%'"; } if (!empty($search_firstname)) { $sql .= " AND p.firstname LIKE '%".$db->escape($search_firstname)."%'"; @@ -115,8 +115,8 @@ $sql .= " AND s.nom LIKE '%".$db->escape($search_company)."%'"; } if (!empty($contactname)) { // acces a partir du module de recherche - $sql .= " AND (p.name LIKE '%".$db->escape($contactname)."%' OR lower(p.firstname) LIKE '%".$db->escape($contactname)."%') "; - $sortfield = "p.name"; + $sql .= " AND (p.lastname LIKE '%".$db->escape($contactname)."%' OR lower(p.firstname) LIKE '%".$db->escape($contactname)."%') "; + $sortfield = "p.lastname"; $sortorder = "ASC"; } @@ -136,7 +136,7 @@ print '