-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken svs on Bio-Formats update #691
Comments
As discussed in IDR meeting:
|
Find 'SVS' format and count images...
Find Datasets...
|
All the svs above are from idr0070. The https://github.com/IDR/idr0070-kerwin-hdbr/blob/master/experimentA/idr0070-experimentA-filePaths.tsv has 400 svs images, so let's just re-import all of them. Steps:
|
To focus on idr0070, max Image ID is 9841818, so we can count etc...
400 svs Image IDs in idr0070
|
Test deleting even a single Image fails (hangs) due to Annotations.
Can't delete using a single Image:ID:
Need to use Fileset ID:
Max Fileset ID for idr0070 is 3552155
Get Fileset IDs....
Need to remove whitespace from each line:
Do the delete....
|
Now re-import....
As omero-server...
On completion...
All files were either imported as 2 (or 1) image - none with 3 images as before:
|
Re-annotate.... Remove label rows from csv on idr-testing...
Reannotate as normal... check_annotations....
|
Checked all 7 of the |
Fixed - test:
Deleted previous OMERO.table:
Create OMERO.table
Create Map annotations
|
The 3 Filesets in https://idr-testing.openmicroscopy.org/webclient/?show=dataset-10461 are still broken. Fileset IDs are: These are all found in
Also, none of these Filesets or Image IDs can be found in the DB via psql.
It turns out that the images, thumbnails, right panel etc showing in the webclient above were all cached in the browser or nginx and have all been deleted and replaced successfully! |
I wonder if you could review the actions above that I have performed on idr-testing (starting at #691 (comment) above) and plan to apply to idr-next for the NGFF release? Summary:
You can see an example of the changes by looking at e.g. |
Final test on
ConnectionTimout! Restarted server and tried command above again... Success...
As wmoore, update filePaths.tsv and annotations.csv...
As omero-server, re-import... 11:32....
|
👍 Looks good to me! (Edit: on idr-testing) |
Import on
|
Try import again.. after updating jars
Seems to be working!! |
Import complete...
as omero-server
|
When testing ome/omero-web#536 on idr-testing, I noticed this issue which I think Seb mentioned was due to a Bio-Formats update (see below)
Deployed on idr-testing from branch at #537, this is returning different
zoomLevelScaling
from previously!?On https://idr.openmicroscopy.org/webclient/img_detail/9840218/ that image has:
But on idr-testing, a different zoomLevelScaling is causing problems:
From slack idr, 28th Feb
Seb: "SVS in particular is a format which went through several changes in recent versions"
Will: Ah - so that bug may not be due to my PR?
Seb:
14:30
where that bug == the resolution levels are different between deployments or that bug == the resolution levels on idr-testing are incorrect?
14:32
actually the bug is clearly in production IDR (and has been addressed in recent Bio-Formats versions)
14:33
https://idr.openmicroscopy.org/webclient/img_detail/9840219/?dataset=10450 is absolutely not a label image, it's a resolution level of the whole slide image
14:34
so this dataset will partly break as part of the OMERO.server upgrade and we might need to consider reimporting these files unfortunately
The text was updated successfully, but these errors were encountered: