Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Crop area does not scale when image is rotated 90 degrees. #24

Open
yajra opened this issue Mar 24, 2018 · 16 comments
Open

Crop area does not scale when image is rotated 90 degrees. #24

yajra opened this issue Mar 24, 2018 · 16 comments
Labels
Milestone

Comments

@yajra
Copy link

yajra commented Mar 24, 2018

When rotating the image clockwise / counter-clockwise by 90 degrees, it seems like the crop area cannot select the whole image (even using original aspect does not work) and is still bound to the initial image size. Is there a way to update the crop area bounds when the image is rotated? Thanks!

You can reproduce the issue by manually setting the angle value.

self.changedAngle(value: 90.0)
@HTKT
Copy link

HTKT commented Aug 19, 2018

I got this same issue. Hope to fix it soon

@ikorich
Copy link
Member

ikorich commented Oct 28, 2018

need use radians, please see ExampleCropViewController line 189

@ikorich ikorich closed this as completed Oct 28, 2018
@HTKT
Copy link

HTKT commented Oct 28, 2018

Hi @ikorich

I tried your new code but the image can not zoom out. I can not crop the image when rotate 90.
Can you please to check it? Thank you

@ikorich
Copy link
Member

ikorich commented Oct 28, 2018

Hi @HTKT
found a problem, I try fix it next week

@ikorich ikorich reopened this Oct 28, 2018
@HTKT
Copy link

HTKT commented Oct 28, 2018

Thanks @ikorich . Hope to fix it soon, i'm using it in my project 👍

@HTKT
Copy link

HTKT commented Nov 6, 2018

Hi @ikorich : Any progress for this issue? Thanks.

@ikorich
Copy link
Member

ikorich commented Nov 7, 2018

@HTKT haven't time :(

@HTKT
Copy link

HTKT commented Nov 23, 2018

Wish you have time to fix this issue soon. :(

@meercha
Copy link

meercha commented Dec 11, 2018

Hello @ikorich!

I'm working on a PR to fix this issue, any suggestions on which button should perform the 90 degree rotation action?

Thanks!

@ikorich
Copy link
Member

ikorich commented Dec 12, 2018

Hi @meercha, need add 2 buttons, rotate left/right and disable >= 90 angle,
there are no way to apply 90+ angle for current logic, need rewrite a lot of math

@HTKT
Copy link

HTKT commented Jan 2, 2019

hi @meercha & @ikorich: any update on this?

@meercha
Copy link

meercha commented Jan 3, 2019

Hello @HTKT! From what I understood, based on the current logic this is not quite possible.

@ikorich
Copy link
Member

ikorich commented Jan 17, 2019

this update will be in v1.1.0

@HTKT
Copy link

HTKT commented Jan 18, 2019

Thanks @ikorich . May i know when v1.1.0 will be released?

@HTKT
Copy link

HTKT commented Feb 10, 2019

Hello @ikorich : Any update for v1.1.0? Thanks

@HTKT
Copy link

HTKT commented Mar 31, 2019

Hello @ikorich:

Hope you are doing well. May i have any update for v1.1.0?
Thanks

@ikorich ikorich added this to the 1.2.0 milestone Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants