Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor angularjs code to use gulp #8

Open
IMS94 opened this issue Oct 9, 2017 · 4 comments
Open

Refactor angularjs code to use gulp #8

IMS94 opened this issue Oct 9, 2017 · 4 comments

Comments

@IMS94
Copy link
Owner

IMS94 commented Oct 9, 2017

The angular JS code used in this app is written inside public/js which is not the correct place where it should be. It should be moved to resources/assets directory and use gulp task to output one js file to the public directory.

@JaredsCode
Copy link

@IMS94 I'd like to work this for you, unless someone else has already

@IMS94
Copy link
Owner Author

IMS94 commented Oct 10, 2017

@JaredsCode Great! Go on. Ask me if you need anything clarified.

@lachieh
Copy link

lachieh commented Oct 24, 2017

This issue needs a bit more information. As far as I can see there are a lot of JS files in the public directory, but not all of them appear to be in use. Is there a list of files that should be compiled into one? Should the gulp script concatenate all the files currently listed in the layouts.master and layouts.app blade templates or should it just copy them?

@IMS94
Copy link
Owner Author

IMS94 commented Nov 1, 2017

@lachieh For the moment, including all the files in public/js into one file is enough. Then we can add the resulting file to latouts.master directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants