Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feedback and error checking when decoding filters on first load #542

Open
KCMertens opened this issue Jan 16, 2025 · 0 comments
Open
Labels
feature: minor Small changes, some extra explanation, look/feel, etc

Comments

@KCMertens
Copy link
Member

Currently the Lucene query AST is barely used when decoding filters, instead the query is heavily simplified.
Usually that is fine, as it only has an effect when the filter query is different from what is in the UI.
But it can create issues when the filter query is generated by an external source (another app linking into the Corpus-Frontend) and that filter doesn't 100% correspond to what we expect given the configured filter widgets.

So,
Ideally, check whether the AST makes sense for the filter we're decoding, and print a warning if it doesn't.
As an extra nice-to-have, similar to the pattern query, have a bailout that just plops the filter in a textbox somewhere if decoding fails?

@KCMertens KCMertens added the feature: minor Small changes, some extra explanation, look/feel, etc label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: minor Small changes, some extra explanation, look/feel, etc
Projects
None yet
Development

No branches or pull requests

1 participant