Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effective coupling #49

Open
zbarni opened this issue Jun 10, 2020 · 2 comments
Open

Effective coupling #49

zbarni opened this issue Jun 10, 2020 · 2 comments

Comments

@zbarni
Copy link

zbarni commented Jun 10, 2020

In the function computing the effective coupling in meanfield_calcs.py on line 971

def effective_coupling_strength(tau_m, tau_s, tau_r, V_0_rel, V_th_rel, J,  mean_input, std_input):
...
    for pre in np.arange(dim):
        for post in np.arange(dim):
            w_ecs[post][pre] = aux_calcs.d_nu_d_nu_in_fb(
                tau_m, tau_s, tau_r, V_th_rel, V_0_rel, J[post][pre],
                mean_input[pre], std_input[pre])[1] # linear (mu) contribution

shouldn't the mean and std of the input depend on the postsynaptic neuron instead of the presynaptic one, i.e., mean_input[pre], std_input[pre] be replaced with mean_input[post], std_input[post]? I think that as it currently is implemented, the resulting entry w_ij does not correspond to the definitions used in the following papers Senk et al., eq. 56, Helias et al., eq. A3, where w_ij depends on the stationary firing rate of the postsynaptic neuron i.

@zbarni
Copy link
Author

zbarni commented Aug 16, 2020

Just wondering if this issue was followed upon?

@moritzlayer
Copy link
Contributor

It's still on my ToDo List, but we need to finish the review of the tests first, before changing any code. Hopefully, Johanna can have a look at the tests after she's back from holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants