Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libpointing npm-package #16

Closed
Izzatbek opened this issue Feb 7, 2017 · 1 comment
Closed

Update libpointing npm-package #16

Izzatbek opened this issue Feb 7, 2017 · 1 comment
Assignees
Labels

Comments

@Izzatbek
Copy link
Collaborator

Izzatbek commented Feb 7, 2017

We need to make sure that the libpointing npm-package works with the latest changes.

@Izzatbek Izzatbek added the bug label Feb 7, 2017
@Izzatbek Izzatbek self-assigned this Feb 7, 2017
@Izzatbek
Copy link
Collaborator Author

Everything compiled fine with the latest Node.js 7.5 with no warnings on my Mac. We need to make sure run npm publish in the libpointing folder. I added this into the wiki. Note also that we are not required to publish each time when we change the main libpointing (C++ version), since the bindings are recompiled each time we install the npm-version of libpointing. But we may prefer publishing the same version for consistency.

However, I found a crash while running the bindings which is not related to the bindings, so opened another ticket and closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant