Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generically support MPS/MPO with multiple site indices and link indices per tensor #54

Open
mtfishman opened this issue Feb 15, 2021 · 0 comments
Assignees

Comments

@mtfishman
Copy link
Member

Not all MPS/MPO functions support MPS/MPO with multiple (or no) site indices and link indices, and often assume there are exactly one site index/link index. An example is that by default, calling:

siteinds(psi)
linkinds(psi)

return Vector{Index}, where in general it would be better if they returned Vector{IndexSet}, allowing for the possibility of zero/more than two site or link indices. This would allow much more general MPS/MPO to be used with built-in ITensor functions (imagine for example Choi matrices with multiple site indices or treating a column or row of a PEPS as an MPS that might get gauged or have gates applied to it).

Supporting this generally could be done fairly easily, but some changes may be breaking like the above change to siteinds/linkinds.

@mtfishman mtfishman self-assigned this Feb 15, 2021
@mtfishman mtfishman transferred this issue from ITensor/ITensors.jl Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant