Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite Tracking {User/Channel/Inviter} Not Found #23

Open
IceSelkie opened this issue Aug 9, 2022 · 2 comments
Open

Invite Tracking {User/Channel/Inviter} Not Found #23

IceSelkie opened this issue Aug 9, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@IceSelkie
Copy link
Owner

The inviteLogging module's messages often return with "Channel Not Found" and or "User Not Found" for both the joiner and sender.

This is problematic since it is then more difficult to track joins and leaves and figure out what is happening, such as during a raid.

Here's a good example, but this applies to: Invite Created, Invite Used, and Invite Deleted.

Screenshot 2022-08-09 at 05 29 49@2x

@IceSelkie IceSelkie added the bug Something isn't working label Aug 9, 2022
@IceSelkie
Copy link
Owner Author

1c1cbb2 and 8c1cde3 attempted to fix this buy moving user logging to pre and post modules so they ensure that users are loaded into the cache before anything else uses it, and removed after anything else might use it.

This didnt work. It probably should have hinted to me that this wouldnt work when channel was not found, even though the channel wasnt deleted before/after/aroundwhen the invite was used. The channel should still have been cached.

This is probably a logic issue, since the channel still exists and is in the channelMap.

@IceSelkie
Copy link
Owner Author

I think I fixed it.

2ba9b0c Fixes userMap not getting updated on user joining a guild (10-11 month old issue that I never noticed until inviteLogging), and fixes call to channelMap not indexing into candidates array (53 day old issue, that was pushed 20 days ago)

Each of these was a breaking issue on both parts that were broken, so unless I have a second breaking issue on one or both of them, this should solve both now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant