Host/service filtering != for costumvar not working correctly

[gbin2265]

Describe the bug

when I do a filtering on the host or service list it doesn't use the != operand correctly in the sql statement.
He converts it as = in the sql and not as !=

To Reproduce

do a basic filtering on the host/service list for a customvar with the operand != and check the sql statement (format=sql).

Expected behavior

I expect to see all services that do not have a value of 1 for the custumvar or that the custumvar does not exist for the service

sql

This you see with the format=sql

	where
		(sub_customvar_flat.flatvalue = '1')
			and (sub_customvar_flat.flatname = 'variablename')
			
	where
		sub_customvar_flat.flatname = 'variablename'))))

For me must this be

flatvalue != '1'

and the second part

flatname != 'variablename'

Your Environment

Latest snapshot for centos 7 on 23/09/02

regards,
Geert

[yhabteab]

Hi @gbin2265, these where clauses are for the subqueries, but the subqueries themselves are wrapped by either the sql IN() or NOT IN() operators, so this is actually not a bug. But while trying to reproduce your issue, we encountered another serious bug that also affects the outcome you expect (filtering for hosts/services that don't set customvar to 1 or not at all).

[gbin2265]

I am not an SQL/PHP specialist, but there was something wrong that I did not get the correct output.

Thank you for your support to resolve this issue.

[nilmerg]

This is related to Icinga/ipl-orm#13 and can be fixed by commenting out this line. Though, cases (thankfully) mentioned in Icinga/ipl-orm#13 are not working anymore then.

[nilmerg]

ref/IP/52121