Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomVarRendererHook implementation must also be able to blacklist properties #5323

Open
raviks789 opened this issue Feb 7, 2025 · 0 comments

Comments

@raviks789
Copy link
Contributor

raviks789 commented Feb 7, 2025

Currently, the monitoring module renders all the the custom variables in an object. This in turn also renders the variable _override_servicevars as shown below, which was introduced by Icinga Director module to conveniently override the custom properties of services in a host. And hence it should not be displayed in the UI. Moreover, as shown in the screenshot it exposes the values of custom properties whose visibility is actually hidden.

Image

This is currently solved by blacklisting the property _override_servicevars in the monitoring module.

But this should be instead handled in the CustomVarRendererHook implementation by adding a feature to blacklist custom variables.

@raviks789 raviks789 changed the title Handle _override_servicevars custom property introduced by Director in CustomVarRendererHook implementation CustomVarRendererHook implementation must also be able to blacklist properties Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant