Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRM key-repeat only repeats once #711

Open
vrazzer opened this issue May 13, 2024 · 0 comments
Open

DRM key-repeat only repeats once #711

vrazzer opened this issue May 13, 2024 · 0 comments

Comments

@vrazzer
Copy link

vrazzer commented May 13, 2024

The change made last year to import the Wayland key binding code into DRM https://github.com/Igalia/cog/commit/7b7c10b781a9cf2b64c1491a6766d68c45808fd8 seems to have semi-broken the key-repeat handling which now only fires once. Changing the repeat-key handler back from g_timeout_source_new() to g_source_new() restores proper operation.

Tried adding explicit g_source_set_ready_time() to the g_timeout_source_new() version, but it made no difference (even canceling and the setting a new timeout). The g_source_new() version included g_source_set_can_recurse=TRUE, but adding that to the g_timeout_source_new() version made no difference. The weirdest part is that after the single repeat, if you release the key and then press again, you get another single repeat.

Have GLib 2.74.6 installed. Nothing but reverting to the g_source_new() version seems to work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant