From 0df4ed32bd2bb4f3daa95afc4434cf4fa7b87355 Mon Sep 17 00:00:00 2001 From: Dan LaManna Date: Thu, 6 Oct 2022 15:33:24 -0400 Subject: [PATCH 1/2] Stop limiting downloads by default --- isic_cli/cli/image.py | 4 ++-- isic_cli/cli/metadata.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/isic_cli/cli/image.py b/isic_cli/cli/image.py index 93f3a72..a18b1e3 100644 --- a/isic_cli/cli/image.py +++ b/isic_cli/cli/image.py @@ -50,10 +50,10 @@ def image(ctx): @click.option( '-l', '--limit', - default=1_000, + default=0, metavar='INTEGER', type=IntRange(min=0), - help='Use a value of 0 to disable the limit.', + help='Download at most LIMIT images. Use a value of 0 to download all images.', ) @click.argument( 'outdir', diff --git a/isic_cli/cli/metadata.py b/isic_cli/cli/metadata.py index 8eb1b61..0b09c48 100644 --- a/isic_cli/cli/metadata.py +++ b/isic_cli/cli/metadata.py @@ -110,10 +110,10 @@ def validate(csv_path: Path): @click.option( '-l', '--limit', - default=1_000, + default=0, metavar='INTEGER', type=IntRange(min=0), - help='Use a value of 0 to disable the limit.', + help='Download at most LIMIT metadata records. Use a value of 0 to download all records.', ) @click.option( '-o', From 78885b03c4288645f3089e417f7c68abc6bc28ac Mon Sep 17 00:00:00 2001 From: Dan LaManna Date: Fri, 7 Oct 2022 00:47:03 -0400 Subject: [PATCH 2/2] Improve help string for --collections --- isic_cli/cli/image.py | 2 +- isic_cli/cli/metadata.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/isic_cli/cli/image.py b/isic_cli/cli/image.py index a18b1e3..91140cc 100644 --- a/isic_cli/cli/image.py +++ b/isic_cli/cli/image.py @@ -43,7 +43,7 @@ def image(ctx): '--collections', default='', help=( - 'Limit the images based on a comma separated string of collection' + 'Filter the images based on a comma separated string of collection' ' ids (see isic collection list).' ), ) diff --git a/isic_cli/cli/metadata.py b/isic_cli/cli/metadata.py index 0b09c48..7f61844 100644 --- a/isic_cli/cli/metadata.py +++ b/isic_cli/cli/metadata.py @@ -103,7 +103,7 @@ def validate(csv_path: Path): type=CommaSeparatedIdentifiers(), default='', help=( - 'Limit the images based on a comma separated list of collection ids e.g. 2,17,42. ' + 'Filter the images based on a comma separated list of collection ids e.g. 2,17,42. ' 'See isic collection list to obtain ids.' ), )